pad.libre-service.eu-etherpad/tests/backend/specs
Richard Hansen f7953ece85 socketio: Delete redundant authentication check
There's no need to perform an authentication check in the socket.io
middleware because `PadMessageHandler.handleMessage` calls
`SecurityMananger.checkAccess` and that now performs authentication
and authorization checks.

This change also improves the user experience: Before, access denials
caused socket.io error events in the client, which `pad.js` mostly
ignores (the user doesn't see anything). Now a deny message is sent
back to the client, which causes `pad.js` to display an obvious
permission denied message.

This also fixes a minor bug: `settings.loadTest` is supposed to bypass
authentication and authorization checks, but they weren't bypassed
because `SecurityManager.checkAccess` did not check
`settings.loadTest`.
2020-10-05 18:12:04 +01:00
..
api tests: test coverage for read only pad ids (#4364) 2020-09-27 19:12:11 +01:00
contentcollector.js tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes 2020-06-05 20:54:16 +01:00
promises.js utils: Fix promise creation accounting bug in promises.timesLimit 2020-09-21 23:16:32 +01:00
socketio.js socketio: Delete redundant authentication check 2020-10-05 18:12:04 +01:00
webaccess.js webaccess: Move pre-authn authz check to a separate hook 2020-09-27 21:19:58 +01:00