mirror of
https://github.com/ether/etherpad-lite.git
synced 2025-02-08 11:12:01 +01:00
3a34db84e6
* Lint functions
* Fix assignment of `settings.minify`
* Use a for loop to avoid copied code for the `minify = true` and
`minify = false` cases
* Put each resource fetch into its own test case
* Check for 200 status code
* Use `.expect()` to check header value
* Use `.expect(fn)` instead of `.then(fn)`
117 lines
4 KiB
JavaScript
117 lines
4 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* caching_middleware is responsible for serving everything under path `/javascripts/`
|
|
* That includes packages as defined in `src/node/utils/tar.json` and probably also plugin code
|
|
*
|
|
*/
|
|
|
|
const common = require('../common');
|
|
const assert = require('../assert-legacy').strict;
|
|
const queryString = require('querystring');
|
|
const settings = require('../../../node/utils/Settings');
|
|
|
|
let agent;
|
|
|
|
/**
|
|
* Hack! Returns true if the resource is not plaintext
|
|
* The file should start with the callback method, so we need the
|
|
* URL.
|
|
*
|
|
* @param {string} fileContent the response body
|
|
* @param {URI} resource resource URI
|
|
* @returns {boolean} if it is plaintext
|
|
*/
|
|
const isPlaintextResponse = (fileContent, resource) => {
|
|
// callback=require.define&v=1234
|
|
const query = (new URL(resource, 'http://localhost')).search.slice(1);
|
|
// require.define
|
|
const jsonp = queryString.parse(query).callback;
|
|
|
|
// returns true if the first letters in fileContent equal the content of `jsonp`
|
|
return fileContent.substring(0, jsonp.length) === jsonp;
|
|
};
|
|
|
|
/**
|
|
* A hack to disable `superagent`'s auto unzip functionality
|
|
*
|
|
* @param {Request} request
|
|
*/
|
|
const disableAutoDeflate = (request) => {
|
|
request._shouldUnzip = () => false;
|
|
};
|
|
|
|
describe(__filename, function () {
|
|
const backups = {};
|
|
const fantasyEncoding = 'brainwaves'; // non-working encoding until https://github.com/visionmedia/superagent/pull/1560 is resolved
|
|
const packages = [
|
|
'/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define',
|
|
'/javascripts/lib/ep_etherpad-lite/static/js/ace2_inner.js?callback=require.define',
|
|
'/javascripts/lib/ep_etherpad-lite/static/js/pad.js?callback=require.define',
|
|
'/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define',
|
|
];
|
|
|
|
before(async function () {
|
|
agent = await common.init();
|
|
backups.settings = {};
|
|
backups.settings.minify = settings.minify;
|
|
});
|
|
after(async function () {
|
|
Object.assign(settings, backups.settings);
|
|
});
|
|
|
|
for (const minify of [false, true]) {
|
|
context(`when minify is ${minify}`, function () {
|
|
before(async function () {
|
|
settings.minify = minify;
|
|
});
|
|
|
|
describe('gets packages uncompressed without Accept-Encoding gzip', function () {
|
|
for (const resource of packages) {
|
|
it(resource, async function () {
|
|
await agent.get(resource)
|
|
.set('Accept-Encoding', fantasyEncoding)
|
|
.use(disableAutoDeflate)
|
|
.expect(200)
|
|
.expect('Content-Type', /application\/javascript/)
|
|
.expect((res) => {
|
|
assert.equal(res.header['content-encoding'], undefined);
|
|
assert(isPlaintextResponse(res.text, resource));
|
|
});
|
|
});
|
|
}
|
|
});
|
|
|
|
describe('gets packages compressed with Accept-Encoding gzip', function () {
|
|
for (const resource of packages) {
|
|
it(resource, async function () {
|
|
await agent.get(resource)
|
|
.set('Accept-Encoding', 'gzip')
|
|
.use(disableAutoDeflate)
|
|
.expect(200)
|
|
.expect('Content-Type', /application\/javascript/)
|
|
.expect('Content-Encoding', 'gzip')
|
|
.expect((res) => {
|
|
assert(!isPlaintextResponse(res.text, resource));
|
|
});
|
|
});
|
|
}
|
|
});
|
|
|
|
it('does not cache content-encoding headers', async function () {
|
|
await agent.get(packages[0])
|
|
.set('Accept-Encoding', fantasyEncoding)
|
|
.expect(200)
|
|
.expect((res) => assert.equal(res.header['content-encoding'], undefined));
|
|
await agent.get(packages[0])
|
|
.set('Accept-Encoding', 'gzip')
|
|
.expect(200)
|
|
.expect('Content-Encoding', 'gzip');
|
|
await agent.get(packages[0])
|
|
.set('Accept-Encoding', fantasyEncoding)
|
|
.expect(200)
|
|
.expect((res) => assert.equal(res.header['content-encoding'], undefined));
|
|
});
|
|
});
|
|
}
|
|
});
|