Ray Bellis
c8e5d87268
api: simplify version table
...
This commit vastly shortens (and simplifies) the version table within
handler/APIHandler.js by building each version's entry incrementally based off
the previous version.
The resulting table has been validated by comparing the "before" and "after"
output of the following loop on both versions of the code (albeit with an
intermediate "sort" step to account for the different insertion order)
for (let v in version) {
let m = version[v];
for (let [k, a] of Object.entries(m)) {
console.log(v, k, a);
}
}
The patch also fixes a few typos, and removes a duplicate definition of
getChatHistory which in each applicable version was defined with two different
parameter lists, but where only the second would be used.
2019-01-22 22:51:22 +01:00
HairyFotr
fce55df2b7
Fix typos
2019-01-16 11:14:04 +01:00
muxator
5b88882e34
LibreOffice: add debugging log statements
2018-11-01 00:22:27 +01:00
muxator
4b8a0ff4ac
LibreOffice: rename variables (conversion is generic and not PDF-specific)
2018-11-01 00:18:26 +01:00
muxator
73d09f1c6c
LibreOffice: rephrase comments (conversion is generic and not PDF-specific)
2018-10-31 22:34:11 +01:00
muxator
df5618b274
ImportHandler: flattened code
...
Removed redundant else, no functional changes
2018-10-31 23:34:15 +01:00
muxator
fcd88de900
ImportHandler: flattened code
...
Removed redundant else, no functional changes
2018-10-31 23:31:23 +01:00
muxator
49a7572cee
ImportHandler: early return by condition inversion
...
No functional changes
2018-10-31 23:28:52 +01:00
muxator
df15daac0e
ImportHandler: early return by condition inversion
...
No functional changes
2018-10-31 23:27:22 +01:00
muxator
12bb97dc2d
ImportHandler: early return by condition inversion
...
No functional changes
2018-10-31 23:24:56 +01:00
muxator
2b8e45e2bd
ImportHandler: anticipated the error checking
...
No functional changes.
2018-10-31 23:22:50 +01:00
muxator
4c2ad68b69
ImportHandler: early return via DeMorgan's law
...
Inverted a boolean condition, no functional changes.
2018-10-31 23:20:55 +01:00
muxator
f652ba8c52
ImportHandler: flattened code
...
Removed redundant else, no functional changes
2018-10-31 23:16:20 +01:00
muxator
fb552b2dbb
ImportHandler: early return via DeMorgan's law
...
Inverted a boolean condition, no functional changes.
2018-10-31 23:15:01 +01:00
muxator
9d104cc4b0
ImportHandler: early return via DeMorgan's law
...
Inverted a boolean condition, no functional changes.
2018-10-31 23:09:27 +01:00
muxator
395db73eb1
ImportHandler: early return by condition inversion
...
No functional changes
2018-10-31 23:00:45 +01:00
muxator
6727a77073
ImportHandler: flatten code
...
No functional changes
2018-10-31 22:55:58 +01:00
Luc Didry
e8558e3497
Allow to import files using soffice
...
Currently, you have to use Abiword to convert odt, pdf and doc files to be able to import those files.
This add soffice as convertor too.
2018-10-31 22:21:48 +01:00
muxator
1a93ab4eb5
db/Pad: reversed truthy condition to make core logic evident
...
Since the original comparison compared for truthy and not for "===", and it's
3 AM now, I blindly negated it, in order to show how fragile it was in the first
instance.
No functional changes.
This is the final commit of this refactoring series.
2018-08-29 03:03:34 +02:00
muxator
69e1bf28aa
db/Pad: reversed condition to make core logic evident. No functional changes
...
Here it was legal to replace a lax comparison with a strict one, since we are
using indexOf(), whose return value is known.
2018-08-29 02:52:26 +02:00
muxator
d931a700b4
db/Pad: reversed condition to make error handling evident. No functional changes
...
Here it was legal to replace a lax comparison with a strict one, since we are
using indexOf(), whose return value is known.
2018-08-29 02:49:40 +02:00
muxator
0e8789863c
db/Pad: removed unuseful else clause, no functional changes
2018-08-29 02:46:08 +02:00
muxator
049f5f2859
db/Pad: removed unuseful else clause, no functional changes
2018-08-29 02:44:51 +02:00
muxator
e90487c3e2
db/GroupManager: early return, no functional changes
2018-08-29 02:42:29 +02:00
muxator
a1d21c0cd2
db/GroupManager: early return, no functional changes
2018-08-29 02:41:53 +02:00
muxator
9ed7608421
db/GroupManager: early return, no functional changes
2018-08-29 02:41:14 +02:00
muxator
da8faa1aa9
db/GroupManager: early return, no functional changes
2018-08-29 02:40:14 +02:00
muxator
f7254a47ea
db/GroupManager: early return, no functional changes
2018-08-29 02:39:05 +02:00
muxator
604952bc97
db/GroupManager: fix indentation
...
This is to make easier on the eye the next change.
2018-08-29 02:38:09 +02:00
muxator
c85bcf0614
db/GroupManager: move inner function on top. No functional change
...
This is to make easier on the eye the next change.
2018-08-29 02:36:25 +02:00
muxator
6af419a88e
SecurityManager.js: early return, no functional changes
2018-08-29 02:33:29 +02:00
muxator
61823e7689
db/AuthorManager: early return, no functional changes
2018-08-29 02:28:40 +02:00
muxator
2b8646a855
db/AuthorManager: early return, no functional changes
2018-08-29 02:28:35 +02:00
muxator
b59818676e
db/API.js: early return to make error handling evident. No functional changes
2018-08-29 02:18:32 +02:00
muxator
67ce19eddb
db/API.js: removed unuseful else clause, no functional changes
2018-08-29 02:16:24 +02:00
muxator
610a6db8c8
db/API.js: early return, no functional changes
2018-08-29 02:13:06 +02:00
muxator
fef57efd46
db/API.js: early return, no functional changes
2018-08-29 02:10:45 +02:00
muxator
42bc0a59e1
db/API.js: early return, no functional changes
2018-08-29 02:09:33 +02:00
muxator
05a33f1533
db/API.js, SessionManager: lot of copied & pasted code in integer parsing
...
Replaced with an early return, no functional changes.
2018-08-29 02:08:05 +02:00
muxator
1d45a63864
db/API.js: early return, no functional changes
2018-08-29 01:57:00 +02:00
muxator
30d814d8ed
db/API.js: early return, no functional changes
2018-08-29 01:57:28 +02:00
muxator
4728736dd8
db/PadManager: early return, no functional changes
2018-08-29 01:47:38 +02:00
muxator
ecb0c41d29
db/PadManager: early return, no functional changes
2018-08-29 01:46:18 +02:00
muxator
12f224ae72
db/PadManager: early return, no functional changes
2018-08-29 01:44:13 +02:00
muxator
391bd79e03
padurlsanitize: early return, no functional changes
2018-08-29 01:38:55 +02:00
muxator
d19436d044
adminsettings: early return, no functional changes.
2018-08-29 01:34:45 +02:00
muxator
b60c0b122c
PadMessageHandler: reversed condition to make core logic evident. No behavioural changes.
...
This one replaces a big "if (message)" negating its truthy condition.
Being lame, I erred on the safe side and wrote a super ugly statement that is
guaranteed to respect the original logic.
In the hope that eventual logic errors become more evident now.
See: https://stackoverflow.com/questions/36661748/what-is-the-exact-negation-of-ifvariable-in-javascript#36661843
2018-08-29 01:23:38 +02:00
muxator
324929ca2d
PadMessageHandler: early return to reduce code depth.
...
Get rid of an else branch to simplify code layout. No functional changes at all.
==============
This series is an attempt to reduce the control structure depth of the code
base, maintaining at the same time its exact same behaviour, bugs included. It
is, in a sense, an initial attempt at a refactoring in the spirit of its
original definition [0].
The idea beyond this refactoring is that reducing the code depth and, sometimes,
inverting some conditions, bugs and logic errors may become easier to spot, and
the code easier to read.
When looked at ignoring whitespace changes, all of these diffs should appear
trivial.
[0] https://refactoring.com/
2018-08-29 00:57:28 +02:00
muxator
fb1f8dd239
toolbar: missing var declaration
...
Without this, Etherpad would fail to start in strict mode:
"ReferenceError: SelectButton is not defined"
2018-08-27 01:34:01 +02:00
muxator
27b3b0ecd2
logs: on the server, use template literals when possible
...
It's just synctactic sugar, but it is always better than executing string
concatenations in one's mind.
Do not do this with files in src/static, because we want to keep IE 11
compatibility.
2018-08-27 01:29:37 +02:00