From e48f2d0190bed4b596cb16c61ee28092493db618 Mon Sep 17 00:00:00 2001 From: John McLear Date: Sun, 3 Jan 2021 12:15:34 +0000 Subject: [PATCH] you meddling nitwit --- tests/frontend/specs/pageupdown.js | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tests/frontend/specs/pageupdown.js b/tests/frontend/specs/pageupdown.js index e96ab176e..1f5d443f4 100644 --- a/tests/frontend/specs/pageupdown.js +++ b/tests/frontend/specs/pageupdown.js @@ -319,15 +319,26 @@ describe('Viewport based Page Up/Down', function () { }, }); }); - - // scrolls up 3 times - it('scrolls down on page down key stroke when top is at 0', async function () { + it('page up when top is at 100 and caret is at bottom', async function () { // by default page down when caret is at end of the document will leave it in the same place. // viewport based pageup/down changes that - const currentLineNumber = helper.caretLineNumber(); + const initialLineNumber = helper.caretLineNumber(); + helper.pageDown(); helper.padOuter$('#outerdocbody').parent().scrollTop(100); helper.pageUp(); - await helper.waitForPromise(() => currentLineNumber < 5); + await helper.waitForPromise(() => helper.caretLineNumber() < initialLineNumber); + }); + + it('page down when top is at 0 and caret is at bottom', async function () { + // by default page down when caret is at end of the document will leave it in the same place. + // viewport based pageup/down changes that + const initialLineNumber = helper.caretLineNumber(); + helper.padOuter$('#outerdocbody').parent().scrollTop(0); + await helper.waitForPromise(() => helper.padOuter$('#outerdocbody').parent().scrollTop() === 0); + helper.pageUp(); // I think this might not be right.. + helper.pageDown(); + + await helper.waitForPromise(() => (helper.caretLineNumber() < initialLineNumber) && (helper.caretLineNumber() > 1)); }); });