libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

webaccess: Use .startsWith() instead of .search()

Browse source
This commit is contained in:
Richard Hansen 2022-01-12 19:08:55 -05:00
parent b9118c22ba
commit dcd43e9849
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/node/hooks/express/webaccess.js
View file

@ -146,8 +146,7 @@ const checkAccess = async (req, res, next) => {
const ctx = {req, res, users: settings.users, next}; const ctx = {req, res, users: settings.users, next};
// If the HTTP basic auth header is present, extract the username and password so it can be given // If the HTTP basic auth header is present, extract the username and password so it can be given
// to authn plugins. // to authn plugins.
const httpBasicAuth = const httpBasicAuth = req.headers.authorization && req.headers.authorization.startsWith('Basic ');
req.headers.authorization && req.headers.authorization.search('Basic ') === 0;
if (httpBasicAuth) { if (httpBasicAuth) {
const userpass = const userpass =
Buffer.from(req.headers.authorization.split(' ')[1], 'base64').toString().split(':'); Buffer.from(req.headers.authorization.split(' ')[1], 'base64').toString().split(':');