From d1c66123dd20a388c439355ad491ffc67c515930 Mon Sep 17 00:00:00 2001 From: John McLear Date: Mon, 8 Feb 2021 07:45:38 +0000 Subject: [PATCH] Update src/tests/frontend/specs/ordered_list.js Co-authored-by: Richard Hansen --- src/tests/frontend/specs/ordered_list.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/tests/frontend/specs/ordered_list.js b/src/tests/frontend/specs/ordered_list.js index fa3840c9d..534899a35 100644 --- a/src/tests/frontend/specs/ordered_list.js +++ b/src/tests/frontend/specs/ordered_list.js @@ -37,7 +37,16 @@ describe('ordered_list.js', function () { const originalHTML = helper.padInner$('body').html(); makeSureShortcutIsDisabled('cmdShiftN'); triggerCtrlShiftShortcut('N'); - await helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML); + try { + // The HTML should not change. Briefly wait for it to change and fail if it does change. + await helper.waitForPromise(() => helper.padInner$('body').html() !== originalHTML, 500); + } catch (err) { + // We want the test to pass if the above wait timed out. (If it timed out that + // means the HTML never changed, which is a good thing.) + // TODO: Re-throw non-"condition never became true" errors to avoid false positives. + } + // This will fail if the above `waitForPromise()` succeeded. + assert.equal(helper.padInner$('body').html(), originalHTML); }); it('does not insert unordered list', function (done) {