libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-01-31 19:02:59 +01:00
Code Issues Projects Releases Wiki Activity

pad_impexp: Use jQuery to build the import failure popup

Browse source 
This reduces the chances of accidentally introducing an XSS
vulnerability.
This commit is contained in:
Richard Hansen 2021-02-07 20:52:28 -05:00 committed by John McLear
parent d869d96a2b
commit cc52811cd0
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/static/js/pad_impexp.js
View file

@ -84,9 +84,12 @@ const padimpexp = (() => {
const msg = html10n.get(`pad.impexp.${known.indexOf(status) !== -1 ? status : 'copypaste'}`); const msg = html10n.get(`pad.impexp.${known.indexOf(status) !== -1 ? status : 'copypaste'}`);
const showError = (fade) => { const showError = (fade) => {
$('#importmessagefail').html( const popup = $('#importmessagefail').empty()
`<strong style="color: red">${html10n.get('pad.impexp.importfailed')}:</strong> ` + .append($('<strong>')
`${msg}`)[(fade ? 'fadeIn' : 'show')](); .css('color', 'red')
.text(`${html10n.get('pad.impexp.importfailed')}: `))
.append(document.createTextNode(msg));
popup[(fade ? 'fadeIn' : 'show')]();
}; };
if ($('#importexport .importmessage').is(':visible')) { if ($('#importexport .importmessage').is(':visible')) {