libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

PadMessageHandler: Avoid unnecessary property lookups

Browse source
This commit is contained in:
Richard Hansen 2021-04-12 23:22:36 -04:00
parent d5c6a44d9c
commit c85391862b
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/node/handler/PadMessageHandler.js
View file

@ -732,12 +732,11 @@ exports.updatePadClients = async (pad) => {
const revChangeset = revision.changeset; const revChangeset = revision.changeset;
const currentTime = revision.meta.timestamp; const currentTime = revision.meta.timestamp;
// next if session has not been deleted // Re-check sessioninfos in case the client disconnected during the above await.
if (sessioninfos[sid] == null) { const sessioninfo = sessioninfos[sid];
continue; if (sessioninfo == null) continue;
}
if (author === sessioninfos[sid].author) { if (author === sessioninfo.author) {
socket.json.send({type: 'COLLABROOM', data: {type: 'ACCEPT_COMMIT', newRev: r}}); socket.json.send({type: 'COLLABROOM', data: {type: 'ACCEPT_COMMIT', newRev: r}});
} else { } else {
const forWire = Changeset.prepareForWire(revChangeset, pad.pool); const forWire = Changeset.prepareForWire(revChangeset, pad.pool);
@ -748,15 +747,12 @@ exports.updatePadClients = async (pad) => {
apool: forWire.pool, apool: forWire.pool,
author, author,
currentTime, currentTime,
timeDelta: currentTime - sessioninfos[sid].time}}; timeDelta: currentTime - sessioninfo.time}};
socket.json.send(wireMsg); socket.json.send(wireMsg);
} }
sessioninfo.time = currentTime;
if (sessioninfos[sid]) { sessioninfo.rev = r;
sessioninfos[sid].time = currentTime;
sessioninfos[sid].rev = r;
}
} }
} }
}; };