libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-01-19 14:13:34 +01:00
Code Issues Projects Releases Wiki Activity

ace2_inner: Delete special arrow key handling

Browse source 
I can't see any reason this would be necessary, and it appears to not
behave as intended (`scroll.scrollWhenPressArrowKeys()` is not invoked
after a continuously held arrow key is finally let up).
This commit is contained in:
Richard Hansen 2021-02-07 01:43:36 -05:00 committed by John McLear
parent 72704a9fbd
commit c39d0606cf
1 changed files with 0 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/static/js/ace2_inner.js
View file

@ -3197,28 +3197,6 @@ function Ace2Inner() {
scroll.setScrollY(caretOffsetTop); scroll.setScrollY(caretOffsetTop);
}, 200); }, 200);
} }
// scroll to viewport when user presses arrow keys and caret is out of the viewport
if ((evt.which === 37 || evt.which === 38 || evt.which === 39 || evt.which === 40)) {
// we use arrowKeyWasReleased to avoid triggering the animation when a key
// is continuously pressed
// this makes the scroll smooth
if (!continuouslyPressingArrowKey(type)) {
// the caret position is not synchronized with the rep.
// For example, when an user presses arrow
// We use getSelection() instead of rep to get the caret position.
// This avoids errors like when down to scroll the pad without releasing the key.
// When the key is released the rep is not
// synchronized, so we don't get the right node where caret is.
const selection = getSelection();
if (selection) {
const arrowUp = evt.which === 38;
const innerHeight = getInnerHeight();
scroll.scrollWhenPressArrowKeys(arrowUp, rep, innerHeight);
}
}
}
} }
if (type === 'keydown') { if (type === 'keydown') {
@ -3263,19 +3241,6 @@ function Ace2Inner() {
}; };
let thisKeyDoesntTriggerNormalize = false; let thisKeyDoesntTriggerNormalize = false;
let arrowKeyWasReleased = true;
const continuouslyPressingArrowKey = (type) => {
let firstTimeKeyIsContinuouslyPressed = false;
if (type === 'keyup') {
arrowKeyWasReleased = true;
} else if (type === 'keydown' && arrowKeyWasReleased) {
firstTimeKeyIsContinuouslyPressed = true;
arrowKeyWasReleased = false;
}
return !firstTimeKeyIsContinuouslyPressed;
};
const doUndoRedo = (which) => { const doUndoRedo = (which) => {
// precond: normalized DOM // precond: normalized DOM