libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-01-31 19:02:59 +01:00
Code Issues Projects Releases Wiki Activity

hooks: Check context nullness, not truthiness

Browse source
This commit is contained in:
Richard Hansen 2021-02-01 00:37:45 -05:00 committed by John McLear
parent fd5d3ce777
commit c11d60c5f6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/static/js/pluginfw/hooks.js
View file

@ -352,7 +352,7 @@ exports.aCallAll = async (hookName, context, cb = null) => {
}; };
exports.callFirst = (hookName, context) => { exports.callFirst = (hookName, context) => {
if (!context) context = {}; if (context == null) context = {};
const predicate = (val) => val.length; const predicate = (val) => val.length;
const hooks = pluginDefs.hooks[hookName] || []; const hooks = pluginDefs.hooks[hookName] || [];
for (const hook of hooks) { for (const hook of hooks) {
@ -366,7 +366,7 @@ exports.aCallFirst = async (hookName, context, cb = null, predicate = null) => {
if (cb != null) { if (cb != null) {
return await attachCallback(exports.aCallFirst(hookName, context, null, predicate), cb); return await attachCallback(exports.aCallFirst(hookName, context, null, predicate), cb);
} }
if (!context) context = {}; if (context == null) context = {};
if (predicate == null) predicate = (val) => val.length; if (predicate == null) predicate = (val) => val.length;
const hooks = pluginDefs.hooks[hookName] || []; const hooks = pluginDefs.hooks[hookName] || [];
for (const hook of hooks) { for (const hook of hooks) {