libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

Changeset: Return a new op object by default when iterating

Browse source 
Reusing the same op object for each iteration can result in very weird
behaviors because previously yielded op objects will get a surprise
mutation.

It is unclear why the code was written to reuse the same object. There
was no comment, nor is there a commit message providing rationale (it
has behaved this way since the very first commit). Perhaps the objects
were reused to improve performance (fewer object allocations that need
to be garbage collected). I do expect this change to reduce
performance somewhat, but not enough to warrant reverting this commit.
This commit is contained in:
Richard Hansen 2021-03-22 03:23:29 -04:00
parent 718da6fc1b
commit b9753dcc71
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/static/js/Changeset.js
View file

@ -126,10 +126,9 @@ exports.opIterator = (opsStr, optStartIndex) => {
return result;
};
let regexResult = nextRegexMatch();
const obj = exports.newOp();
const next = (optObj) => {
const op = (optObj || obj);
const next = (optOp) => {
const op = optOp || exports.newOp();
if (regexResult[0]) {
op.attribs = regexResult[1];
op.lines = exports.parseNum(regexResult[2] || 0);