libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

remote_runner: Always call browser.quit()

Browse source
This commit is contained in:
Richard Hansen 2021-05-03 00:43:23 -04:00
parent 081f739a8d
commit 8baacd514e
1 changed files with 27 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/tests/frontend/travis/remote_runner.js
View file

@ -42,6 +42,7 @@ const sauceTestWorker = async.queue(async ({name, pfx, testSettings}) => {
const browser = wd.remote(config, 'promiseChain'); const browser = wd.remote(config, 'promiseChain');
await browser.init(testSettings); await browser.init(testSettings);
const url = `https://saucelabs.com/jobs/${browser.sessionID}`; const url = `https://saucelabs.com/jobs/${browser.sessionID}`;
try {
await browser.get('http://localhost:9001/tests/frontend/'); await browser.get('http://localhost:9001/tests/frontend/');
log(`Remote sauce test started! ${url}`, pfx); log(`Remote sauce test started! ${url}`, pfx);
// @TODO this should be configured in testSettings, see // @TODO this should be configured in testSettings, see
@ -66,8 +67,10 @@ const sauceTestWorker = async.queue(async ({name, pfx, testSettings}) => {
} }
await new Promise((resolve) => setTimeout(resolve, 5000)); await new Promise((resolve) => setTimeout(resolve, 5000));
} }
} finally {
log(`Remote sauce test finished! ${url}`, pfx); log(`Remote sauce test finished! ${url}`, pfx);
await browser.quit(); await browser.quit();
}
}, 6); // run 6 tests in parrallel }, 6); // run 6 tests in parrallel
Promise.all([ Promise.all([