From 87341af42900c5d975cd39944611012cfe230914 Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Tue, 9 Feb 2021 01:02:16 -0500
Subject: [PATCH] GitHub workflows: Install Node.js v12

I'm not sure how these tests ever worked. I guess some version of
Node.js and npm come pre-installed on the ubuntu-latest images?

I would have prefered to use Node.js v10 because that is our current
minimum supported version, but we have a surprising number of tests
that don't work on Node.js v10 (mostly due to `assert.match()`, which
was added in Node.js v12).
---
 .github/workflows/backend-tests.yml        | 8 ++++++++
 .github/workflows/frontend-admin-tests.yml | 4 ++++
 .github/workflows/frontend-tests.yml       | 8 ++++++++
 .github/workflows/lint-package-lock.yml    | 4 ++++
 .github/workflows/load-test.yml            | 8 ++++++++
 .github/workflows/rate-limit.yml           | 4 ++++
 6 files changed, 36 insertions(+)

diff --git a/.github/workflows/backend-tests.yml b/.github/workflows/backend-tests.yml
index a6a0d0139..21bb0c698 100644
--- a/.github/workflows/backend-tests.yml
+++ b/.github/workflows/backend-tests.yml
@@ -17,6 +17,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Install libreoffice
       run: |
         sudo add-apt-repository -y ppa:libreoffice/ppa
@@ -43,6 +47,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Install libreoffice
       run: |
         sudo add-apt-repository -y ppa:libreoffice/ppa
diff --git a/.github/workflows/frontend-admin-tests.yml b/.github/workflows/frontend-admin-tests.yml
index 6f95a6c7f..e42aa3bb2 100644
--- a/.github/workflows/frontend-admin-tests.yml
+++ b/.github/workflows/frontend-admin-tests.yml
@@ -11,6 +11,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Run sauce-connect-action
       shell: bash
       env:
diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml
index 70cb197a3..0d5832be7 100644
--- a/.github/workflows/frontend-tests.yml
+++ b/.github/workflows/frontend-tests.yml
@@ -11,6 +11,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Run sauce-connect-action
       shell: bash
       env:
@@ -47,6 +51,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Run sauce-connect-action
       shell: bash
       env:
diff --git a/.github/workflows/lint-package-lock.yml b/.github/workflows/lint-package-lock.yml
index beef64ffe..a9596aa3c 100644
--- a/.github/workflows/lint-package-lock.yml
+++ b/.github/workflows/lint-package-lock.yml
@@ -17,6 +17,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Install lockfile-lint
       run: npm install lockfile-lint
 
diff --git a/.github/workflows/load-test.yml b/.github/workflows/load-test.yml
index 056930ecb..98379dfe8 100644
--- a/.github/workflows/load-test.yml
+++ b/.github/workflows/load-test.yml
@@ -17,6 +17,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Install all dependencies and symlink for ep_etherpad-lite
       run: src/bin/installDeps.sh
 
@@ -39,6 +43,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: Install etherpad-load-test
       run: sudo npm install -g etherpad-load-test
 
diff --git a/.github/workflows/rate-limit.yml b/.github/workflows/rate-limit.yml
index 667558114..0849f8e06 100644
--- a/.github/workflows/rate-limit.yml
+++ b/.github/workflows/rate-limit.yml
@@ -16,6 +16,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v2
+      with:
+        node-version: 12
+
     - name: docker network
       run: docker network create --subnet=172.23.42.0/16 ep_net