libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-08 03:02:03 +01:00
Code Issues Projects Releases Wiki Activity

hooks: Always return a list from aCallFirst and callFirst

Browse source 
Every existing caller of `aCallFirst` expects a list and will throw an
exception if given `undefined`. (Nobody calls `callFirst`, except
maybe plugins.)
This commit is contained in:
Richard Hansen 2020-09-05 15:11:06 -04:00 committed by John McLear
parent 9f288480e8
commit 6f3e7d14f6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/static/js/pluginfw/hooks.js
View file

@ -34,14 +34,14 @@ exports.syncMapFirst = function (lst, fn) {
result = fn(lst[i]) result = fn(lst[i])
if (result.length) return result; if (result.length) return result;
} }
return undefined; return [];
} }
exports.mapFirst = function (lst, fn, cb) { exports.mapFirst = function (lst, fn, cb) {
var i = 0; var i = 0;
var next = function () { var next = function () {
if (i >= lst.length) return cb(undefined); if (i >= lst.length) return cb(null, []);
fn(lst[i++], function (err, result) { fn(lst[i++], function (err, result) {
if (err) return cb(err); if (err) return cb(err);
if (result.length) return cb(null, result); if (result.length) return cb(null, result);