libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

Move title attribute of buttons from <span> to <a>

Browse source 
The `.toolbar ul li a` that holds the `span.button` has a
padding of `4px 5px`. This means if the mouse is on the edge
of the button the `:hover` state is active but the relevant
tooltip does not show up. Moving the `title` attribute to
the `<a>` itself solves this problem.

Also removed some extra whitespace.
This commit is contained in:
Prateek Saxena 2014-10-11 20:13:19 +05:30
parent 6ec55309a7
commit 437b2bfc64
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/node/utils/toolbar.js
View file

@ -99,8 +99,8 @@ _.extend(Button.prototype, {
"data-key": this.attributes.command, "data-key": this.attributes.command,
}; };
return tag("li", liAttributes, return tag("li", liAttributes,
tag("a", { "class": this.grouping }, tag("a", { "class": this.grouping, "data-l10n-id": this.attributes.localizationId },
tag("span", { "class": " "+ this.attributes.class, "data-l10n-id": this.attributes.localizationId }) tag("span", { "class": " "+ this.attributes.class })
) )
); );
} }
@ -203,13 +203,13 @@ module.exports = {
settings: defaultButtonAttributes("settings"), settings: defaultButtonAttributes("settings"),
embed: defaultButtonAttributes("embed"), embed: defaultButtonAttributes("embed"),
showusers: defaultButtonAttributes("showusers"), showusers: defaultButtonAttributes("showusers"),
timeslider_export: { timeslider_export: {
command: "import_export", command: "import_export",
localizationId: "timeslider.toolbar.exportlink.title", localizationId: "timeslider.toolbar.exportlink.title",
class: "buttonicon buttonicon-import_export" class: "buttonicon buttonicon-import_export"
}, },
timeslider_returnToPad: { timeslider_returnToPad: {
command: "timeslider_returnToPad", command: "timeslider_returnToPad",
localizationId: "timeslider.toolbar.returnbutton", localizationId: "timeslider.toolbar.returnbutton",