libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

Changeset: Add TODO comments for issues noticed

Browse source
This commit is contained in:
Richard Hansen 2021-11-19 01:10:04 -05:00
parent f1eb7a25a6
commit 2fc06a0884
3 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/node/utils/padDiff.js
View file

@ -383,6 +383,8 @@ PadDiff.prototype._createDeletionChangeset = function (cs, startAText, apool) {
const oldValue = oldAttribs.get(key);
if (oldValue !== value) backAttribs.set(key, oldValue);
}
// TODO: backAttribs does not restore removed attributes (it is missing attributes that
// are in oldAttribs but not in attribs). I don't know if that is intentional.
return backAttribs.toString();
});

2
src/static/js/Changeset.js
View file

@ -2098,6 +2098,8 @@ exports.inverse = (cs, lines, alines, pool) => {
const oldValue = oldAttribs.get(key) || '';
if (oldValue !== value) backAttribs.set(key, oldValue);
}
// TODO: backAttribs does not restore removed attributes (it is missing attributes that
// are in oldAttribs but not in attribs). I don't know if that is intentional.
return backAttribs.toString();
});
consumeAttribRuns(csOp.chars, (len, attribs, endsLine) => {

6
src/static/js/contentcollector.js
View file

@ -235,6 +235,9 @@ const makeContentCollector = (collectStyles, abrowser, apool, className2Author)
// to enable the content collector to store key-value attributes
// see https://github.com/ether/etherpad-lite/issues/2567 for more information
// in long term the contentcollector should be refactored to get rid of this workaround
//
// TODO: This approach doesn't support changing existing values: if both 'foo::bar' and
// 'foo::baz' are in state.attribs then the last one encountered while iterating will win.
const ATTRIBUTE_SPLIT_STRING = '::';
// see if attributeString is splittable
@ -265,6 +268,9 @@ const makeContentCollector = (collectStyles, abrowser, apool, className2Author)
const attribs = new AttributeMap(apool)
.set('lmkr', '1')
.set('insertorder', 'first')
// TODO: Converting all falsy values in state.lineAttributes into removals is awkward.
// Better would be to never add 0, false, null, or undefined to state.lineAttributes in the
// first place (I'm looking at you, state.lineAttributes.start).
.update(Object.entries(state.lineAttributes).map(([k, v]) => [k, v || '']), true);
lines.appendText('*', attribs.toString());
};