libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-02-01 03:12:42 +01:00
Code Issues Projects Releases Wiki Activity

Pad: Check nullness before checking Number.isInteger()

Browse source 
This makes it easier to troubleshoot if the value is null.
This commit is contained in:
Richard Hansen 2021-12-01 18:20:44 -05:00
parent 01ffa070ee
commit 2dbda3fe7e
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/node/db/Pad.js
View file

@ -610,6 +610,7 @@ class Pad {
assert.equal(typeof this.id, 'string'); assert.equal(typeof this.id, 'string');
const head = this.getHeadRevisionNumber(); const head = this.getHeadRevisionNumber();
assert(head != null);
assert(Number.isInteger(head)); assert(Number.isInteger(head));
assert(head >= -1); assert(head >= -1);
@ -618,6 +619,7 @@ class Pad {
assert.equal(this.getSavedRevisionsNumber(), savedRevisionsList.length); assert.equal(this.getSavedRevisionsNumber(), savedRevisionsList.length);
let prevSavedRev = null; let prevSavedRev = null;
for (const rev of savedRevisionsList) { for (const rev of savedRevisionsList) {
assert(rev != null);
assert(Number.isInteger(rev)); assert(Number.isInteger(rev));
assert(rev >= 0); assert(rev >= 0);
assert(rev <= head); assert(rev <= head);
@ -692,6 +694,7 @@ class Pad {
assert.deepEqual(this.atext, atext); assert.deepEqual(this.atext, atext);
assert.deepEqual(this.getAllAuthors().sort(), [...authorIds].sort()); assert.deepEqual(this.getAllAuthors().sort(), [...authorIds].sort());
assert(this.chatHead != null);
assert(Number.isInteger(this.chatHead)); assert(Number.isInteger(this.chatHead));
assert(this.chatHead >= -1); assert(this.chatHead >= -1);
let c; let c;