libre-service.eu/pad.libre-service.eu-etherpad
libre-service.eu/pad.libre-service.eu-etherpad
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-01-19 14:13:34 +01:00
Code Issues Projects Releases Wiki Activity

tests: remove more edge settimeout issues (#4060)

Browse source
This commit is contained in:
John McLear 2020-05-29 20:07:27 +01:00 committed by GitHub
parent be2ba34d3c
commit 174e68d468
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
tests/frontend/specs/select_formatting_buttons.js
View file

@ -63,18 +63,22 @@ describe("select formatting buttons when selection has style applied", function(
} }
var applyStyleOnLineOnFullLineAndRemoveSelection = function(line, style, selectTarget, cb) { var applyStyleOnLineOnFullLineAndRemoveSelection = function(line, style, selectTarget, cb) {
// see if line html has changed
var inner$ = helper.padInner$;
var oldLineHTML = inner$.find("div")[line];
applyStyleOnLine(style, line); applyStyleOnLine(style, line);
// we have to give some time to Etherpad detects the selection changed helper.waitFor(function(){
setTimeout(function() { var lineHTML = inner$.find("div")[line];
return lineHTML !== oldLineHTML;
});
// remove selection from previous line // remove selection from previous line
selectLine(line + 1); selectLine(line + 1);
setTimeout(function() { setTimeout(function() {
// select the text or place the caret on a position that // select the text or place the caret on a position that
// has the formatting text applied previously // has the formatting text applied previously
selectTarget(line); selectTarget(line);
cb(); cb();
}, 1000);
}, 1000); }, 1000);
} }