pad.libre-service.eu-etherpad/tests/backend/specs/contentcollector.js

'use strict';

/*
 * While importexport tests target the `setHTML` API endpoint, which is nearly identical to what
 * happens when a user manually imports a document via the UI, the contentcollector tests here don't
 * use rehype to process the document. Rehype removes spaces and newĺines were applicable, so the
 * expected results here can differ from importexport.js.
 *
 * If you add tests here, please also add them to importexport.js
 */

const AttributePool = require('ep_etherpad-lite/static/js/AttributePool');
const assert = require('assert').strict;
const cheerio = require('ep_etherpad-lite/node_modules/cheerio');
const contentcollector = require('ep_etherpad-lite/static/js/contentcollector');

const tests = {
  nestedLi: {
    description: 'Complex nested Li',
    html: '<!doctype html><html><body><ol><li>one</li><li><ol><li>1.1</li></ol></li><li>two</li></ol></body></html>',
    wantLineAttribs: [
      '*0*1*2*3+1+3', '*0*4*2*5+1+3', '*0*1*2*5+1+3',
    ],
    wantText: [
      '*one', '*1.1', '*two',
    ],
  },
  complexNest: {
    description: 'Complex list of different types',
    html: '<!doctype html><html><body><ul class="bullet"><li>one</li><li>two</li><li>0</li><li>1</li><li>2<ul class="bullet"><li>3</li><li>4</li></ul></li></ul><ol class="number"><li>item<ol class="number"><li>item1</li><li>item2</li></ol></li></ol></body></html>',
    wantLineAttribs: [
      '*0*1*2+1+3',
      '*0*1*2+1+3',
      '*0*1*2+1+1',
      '*0*1*2+1+1',
      '*0*1*2+1+1',
      '*0*3*2+1+1',
      '*0*3*2+1+1',
      '*0*4*2*5+1+4',
      '*0*6*2*7+1+5',
      '*0*6*2*7+1+5',
    ],
    wantText: [
      '*one',
      '*two',
      '*0',
      '*1',
      '*2',
      '*3',
      '*4',
      '*item',
      '*item1',
      '*item2',
    ],
  },
  ul: {
    description: 'Tests if uls properly get attributes',
    html: '<html><body><ul><li>a</li><li>b</li></ul><div>div</div><p>foo</p></body></html>',
    wantLineAttribs: ['*0*1*2+1+1', '*0*1*2+1+1', '+3', '+3'],
    wantText: ['*a', '*b', 'div', 'foo'],
  },
  ulIndented: {
    description: 'Tests if indented uls properly get attributes',
    html: '<html><body><ul><li>a</li><ul><li>b</li></ul><li>a</li></ul><p>foo</p></body></html>',
    wantLineAttribs: ['*0*1*2+1+1', '*0*3*2+1+1', '*0*1*2+1+1', '+3'],
    wantText: ['*a', '*b', '*a', 'foo'],
  },
  ol: {
    description: 'Tests if ols properly get line numbers when in a normal OL',
    html: '<html><body><ol><li>a</li><li>b</li><li>c</li></ol><p>test</p></body></html>',
    wantLineAttribs: ['*0*1*2*3+1+1', '*0*1*2*3+1+1', '*0*1*2*3+1+1', '+4'],
    wantText: ['*a', '*b', '*c', 'test'],
    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
  },
  lineDoBreakInOl: {
    description: 'A single completely empty line break within an ol should reset count if OL is closed off..',
    html: '<html><body><ol><li>should be 1</li></ol><p>hello</p><ol><li>should be 1</li><li>should be 2</li></ol><p></p></body></html>',
    wantLineAttribs: ['*0*1*2*3+1+b', '+5', '*0*1*2*4+1+b', '*0*1*2*4+1+b', ''],
    wantText: ['*should be 1', 'hello', '*should be 1', '*should be 2', ''],
    noteToSelf: "Shouldn't include attribute marker in the <p> line",
  },
  testP: {
    description: 'A single <p></p> should create a new line',
    html: '<html><body><p></p><p></p></body></html>',
    wantLineAttribs: ['', ''],
    wantText: ['', ''],
    noteToSelf: '<p></p>should create a line break but not break numbering',
  },
  nestedOl: {
    description: 'Tests if ols properly get line numbers when in a normal OL',
    html: '<html><body>a<ol><li>b<ol><li>c</li></ol></ol>notlist<p>foo</p></body></html>',
    wantLineAttribs: ['+1', '*0*1*2*3+1+1', '*0*4*2*5+1+1', '+7', '+3'],
    wantText: ['a', '*b', '*c', 'notlist', 'foo'],
    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
  },
  nestedOl2: {
    description: 'First item being an UL then subsequent being OL will fail',
    html: '<html><body><ul><li>a<ol><li>b</li><li>c</li></ol></li></ul></body></html>',
    wantLineAttribs: ['+1', '*0*1*2*3+1+1', '*0*4*2*5+1+1'],
    wantText: ['a', '*b', '*c'],
    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
    disabled: true,
  },
  lineDontBreakOL: {
    description: 'A single completely empty line break within an ol should NOT reset count',
    html: '<html><body><ol><li>should be 1</li><p></p><li>should be 2</li><li>should be 3</li></ol><p></p></body></html>',
    wantLineAttribs: [],
    wantText: ['*should be 1', '*should be 2', '*should be 3'],
    noteToSelf: "<p></p>should create a line break but not break numbering -- This is what I can't get working!",
    disabled: true,
  },
  ignoreAnyTagsOutsideBody: {
    description: 'Content outside body should be ignored',
    html: '<html><head><title>title</title><style></style></head><body>empty<br></body></html>',
    wantLineAttribs: ['+5'],
    wantText: ['empty'],
  },
  lineWithMultipleSpaces: {
    description: 'Multiple spaces should be preserved',
    html: '<html><body>Text with  more   than    one space.<br></body></html>',
    wantLineAttribs: ['+10'],
    wantText: ['Text with  more   than    one space.'],
  },
  lineWithMultipleNonBreakingAndNormalSpaces: {
    description: 'non-breaking and normal space should be preserved',
    html: '<html><body>Text&nbsp;with&nbsp; more&nbsp;&nbsp;&nbsp;than   &nbsp;one space.<br></body></html>',
    wantLineAttribs: ['+10'],
    wantText: ['Text with  more   than    one space.'],
  },
  multiplenbsp: {
    description: 'Multiple nbsp should be preserved',
    html: '<html><body>&nbsp;&nbsp;<br></body></html>',
    wantLineAttribs: ['+2'],
    wantText: ['  '],
  },
  multipleNonBreakingSpaceBetweenWords: {
    description: 'Multiple nbsp between words ',
    html: '<html><body>&nbsp;&nbsp;word1&nbsp;&nbsp;word2&nbsp;&nbsp;&nbsp;word3<br></body></html>',
    wantLineAttribs: ['+m'],
    wantText: ['  word1  word2   word3'],
  },
  nonBreakingSpacePreceededBySpaceBetweenWords: {
    description: 'A non-breaking space preceeded by a normal space',
    html: '<html><body> &nbsp;word1 &nbsp;word2 &nbsp;word3<br></body></html>',
    wantLineAttribs: ['+l'],
    wantText: ['  word1  word2  word3'],
  },
  nonBreakingSpaceFollowededBySpaceBetweenWords: {
    description: 'A non-breaking space followed by a normal space',
    html: '<html><body>&nbsp; word1&nbsp; word2&nbsp; word3<br></body></html>',
    wantLineAttribs: ['+l'],
    wantText: ['  word1  word2  word3'],
  },
  spacesAfterNewline: {
    description: 'Don\'t collapse spaces that follow a newline',
    html: '<!doctype html><html><body>something<br>             something<br></body></html>',
    wantLineAttribs: ['+9', '+m'],
    wantText: ['something', '             something'],
  },
  spacesAfterNewlineP: {
    description: 'Don\'t collapse spaces that follow a empty paragraph',
    html: '<!doctype html><html><body>something<p></p>             something<br></body></html>',
    wantLineAttribs: ['+9', '', '+m'],
    wantText: ['something', '', '             something'],
  },
  spacesAtEndOfLine: {
    description: 'Don\'t collapse spaces that preceed/follow a newline',
    html: '<html><body>something            <br>             something<br></body></html>',
    wantLineAttribs: ['+l', '+m'],
    wantText: ['something            ', '             something'],
  },
  spacesAtEndOfLineP: {
    description: 'Don\'t collapse spaces that preceed/follow a empty paragraph',
    html: '<html><body>something            <p></p>             something<br></body></html>',
    wantLineAttribs: ['+l', '', '+m'],
    wantText: ['something            ', '', '             something'],
  },
  nonBreakingSpacesAfterNewlines: {
    description: 'Don\'t collapse non-breaking spaces that follow a newline',
    html: '<html><body>something<br>&nbsp;&nbsp;&nbsp;something<br></body></html>',
    wantLineAttribs: ['+9', '+c'],
    wantText: ['something', '   something'],
  },
  nonBreakingSpacesAfterNewlinesP: {
    description: 'Don\'t collapse non-breaking spaces that follow a paragraph',
    html: '<html><body>something<p></p>&nbsp;&nbsp;&nbsp;something<br></body></html>',
    wantLineAttribs: ['+9', '', '+c'],
    wantText: ['something', '', '   something'],
  },
  preserveSpacesInsideElements: {
    description: 'Preserve all spaces when multiple are present',
    html: '<html><body>Need <span> more </span> space<i>  s </i> !<br></body></html>',
    wantLineAttribs: ['+h*0+4+2'],
    wantText: ['Need  more  space  s  !'],
  },
  preserveSpacesAcrossNewlines: {
    description: 'Newlines and multiple spaces across newlines should be preserved',
    html: `
      <html><body>Need
          <span> more </span>
          space
          <i>  s </i>
          !<br></body></html>`,
    wantLineAttribs: ['+19*0+4+b'],
    wantText: ['Need           more           space            s           !'],
  },
  multipleNewLinesAtBeginning: {
    description: 'Multiple new lines at the beginning should be preserved',
    html: '<html><body><br><br><p></p><p></p>first line<br><br>second line<br></body></html>',
    wantLineAttribs: ['', '', '', '', '+a', '', '+b'],
    wantText: ['', '', '', '', 'first line', '', 'second line'],
  },
  multiLineParagraph: {
    description: 'A paragraph with multiple lines should not loose spaces when lines are combined',
    html: `<html><body><p>
а б в г ґ д е є ж з и і ї й к л м н о
п р с т у ф х ц ч ш щ ю я ь</p>
</body></html>`,
    wantLineAttribs: ['+1t'],
    wantText: ['а б в г ґ д е є ж з и і ї й к л м н о п р с т у ф х ц ч ш щ ю я ь'],
  },
  multiLineParagraphWithPre: {
    description: 'lines in preformatted text should be kept intact',
    html: `<html><body><p>
а б в г ґ д е є ж з и і ї й к л м н о</p><pre>multiple
lines
in
pre
</pre><p>п р с т у ф х ц ч ш щ ю я
ь</p>
</body></html>`,
    wantLineAttribs: ['+11', '+8', '+5', '+2', '+3', '+r'],
    wantText: [
      'а б в г ґ д е є ж з и і ї й к л м н о',
      'multiple',
      'lines',
      'in',
      'pre',
      'п р с т у ф х ц ч ш щ ю я ь',
    ],
  },
  preIntroducesASpace: {
    description: 'pre should be on a new line not preceeded by a space',
    html: `<html><body><p>
    1
</p><pre>preline
</pre></body></html>`,
    wantLineAttribs: ['+6', '+7'],
    wantText: ['    1 ', 'preline'],
  },
  dontDeleteSpaceInsideElements: {
    description: 'Preserve spaces on the beginning and end of a element',
    html: '<html><body>Need<span> more </span>space<i> s </i>!<br></body></html>',
    wantLineAttribs: ['+f*0+3+1'],
    wantText: ['Need more space s !'],
  },
  dontDeleteSpaceOutsideElements: {
    description: 'Preserve spaces outside elements',
    html: '<html><body>Need <span>more</span> space <i>s</i> !<br></body></html>',
    wantLineAttribs: ['+g*0+1+2'],
    wantText: ['Need more space s !'],
  },
  dontDeleteSpaceAtEndOfElement: {
    description: 'Preserve spaces at the end of an element',
    html: '<html><body>Need <span>more </span>space <i>s </i>!<br></body></html>',
    wantLineAttribs: ['+g*0+2+1'],
    wantText: ['Need more space s !'],
  },
  dontDeleteSpaceAtBeginOfElements: {
    description: 'Preserve spaces at the start of an element',
    html: '<html><body>Need<span> more</span> space<i> s</i> !<br></body></html>',
    wantLineAttribs: ['+f*0+2+2'],
    wantText: ['Need more space s !'],
  },
};

describe(__filename, function () {
  for (const test of Object.keys(tests)) {
    const testObj = tests[test];
    describe(test, function () {
      if (testObj.disabled) {
        return xit('DISABLED:', test, function (done) {
          done();
        });
      }

      it(testObj.description, async function () {
        const $ = cheerio.load(testObj.html); // Load HTML into Cheerio
        const doc = $('body')[0]; // Creates a dom-like representation of HTML
        // Create an empty attribute pool
        const apool = new AttributePool();
        // Convert a dom tree into a list of lines and attribute liens
        // using the content collector object
        const cc = contentcollector.makeContentCollector(true, null, apool);
        cc.collectContent(doc);
        const result = cc.finish();
        const gotAttributes = result.lineAttribs;
        const wantAttributes = testObj.wantLineAttribs;
        const gotText = new Array(result.lines);
        const wantText = testObj.wantText;

        assert.deepEqual(gotText[0], wantText);
        assert.deepEqual(gotAttributes, wantAttributes);
      });
    });
  }
});


function arraysEqual(a, b) {
  if (a === b) return true;
  if (a == null || b == null) return false;
  if (a.length !== b.length) return false;

  // If you don't care about the order of the elements inside
  // the array, you should sort both arrays here.
  // Please note that calling sort on an array will modify that array.
  // you might want to clone your array first.

  for (let i = 0; i < a.length; ++i) {
    if (a[i] !== b[i]) return false;
  }
  return true;
}
-												cc tests: enable second nestedOL test

											
										
										
											2020-12-18 06:40:33 +01:00
+								'use strict';
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								/*
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								 * While importexport tests target the `setHTML` API endpoint, which is nearly identical to what
 								 * happens when a user manually imports a document via the UI, the contentcollector tests here don't
 								 * use rehype to process the document. Rehype removes spaces and newĺines were applicable, so the
 								 * expected results here can differ from importexport.js.
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								 *
 								 * If you add tests here, please also add them to importexport.js
 								 */
-												cc tests: enable second nestedOL test

											
										
										
											2020-12-18 06:40:33 +01:00
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								const AttributePool = require('ep_etherpad-lite/static/js/AttributePool');
-												tests: Use `assert.deepEqual()` to simplify equality checks

											
										
										
											2021-01-24 07:34:28 +01:00
+								const assert = require('assert').strict;
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								const cheerio = require('ep_etherpad-lite/node_modules/cheerio');
 								const contentcollector = require('ep_etherpad-lite/static/js/contentcollector');
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
 								const tests = {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  nestedLi: {
 								    description: 'Complex nested Li',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    html: '<!doctype html><html><body><ol><li>one</li><li><ol><li>1.1</li></ol></li><li>two</li></ol></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: [
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								      '*0*1*2*3+1+3', '*0*4*2*5+1+3', '*0*1*2*5+1+3',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    ],
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantText: [
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								      '*one', '*1.1', '*two',
 								    ],
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  complexNest: {
 								    description: 'Complex list of different types',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    html: '<!doctype html><html><body><ul class="bullet"><li>one</li><li>two</li><li>0</li><li>1</li><li>2<ul class="bullet"><li>3</li><li>4</li></ul></li></ul><ol class="number"><li>item<ol class="number"><li>item1</li><li>item2</li></ol></li></ol></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: [
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								      '*0*1*2+1+3',
 								      '*0*1*2+1+3',
 								      '*0*1*2+1+1',
 								      '*0*1*2+1+1',
 								      '*0*1*2+1+1',
 								      '*0*3*2+1+1',
 								      '*0*3*2+1+1',
 								      '*0*4*2*5+1+4',
 								      '*0*6*2*7+1+5',
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								      '*0*6*2*7+1+5',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    ],
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantText: [
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								      '*one',
 								      '*two',
 								      '*0',
 								      '*1',
 								      '*2',
 								      '*3',
 								      '*4',
 								      '*item',
 								      '*item1',
 								      '*item2',
 								    ],
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
 								  ul: {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    description: 'Tests if uls properly get attributes',
 								    html: '<html><body><ul><li>a</li><li>b</li></ul><div>div</div><p>foo</p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['*0*1*2+1+1', '*0*1*2+1+1', '+3', '+3'],
 								    wantText: ['*a', '*b', 'div', 'foo'],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  },
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  ulIndented: {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    description: 'Tests if indented uls properly get attributes',
 								    html: '<html><body><ul><li>a</li><ul><li>b</li></ul><li>a</li></ul><p>foo</p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['*0*1*2+1+1', '*0*3*2+1+1', '*0*1*2+1+1', '+3'],
 								    wantText: ['*a', '*b', '*a', 'foo'],
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
 								  ol: {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    description: 'Tests if ols properly get line numbers when in a normal OL',
 								    html: '<html><body><ol><li>a</li><li>b</li><li>c</li></ol><p>test</p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['*0*1*2*3+1+1', '*0*1*2*3+1+1', '*0*1*2*3+1+1', '+4'],
 								    wantText: ['*a', '*b', '*c', 'test'],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  lineDoBreakInOl: {
 								    description: 'A single completely empty line break within an ol should reset count if OL is closed off..',
 								    html: '<html><body><ol><li>should be 1</li></ol><p>hello</p><ol><li>should be 1</li><li>should be 2</li></ol><p></p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['*0*1*2*3+1+b', '+5', '*0*1*2*4+1+b', '*0*1*2*4+1+b', ''],
 								    wantText: ['*should be 1', 'hello', '*should be 1', '*should be 2', ''],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    noteToSelf: "Shouldn't include attribute marker in the <p> line",
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  testP: {
 								    description: 'A single <p></p> should create a new line',
 								    html: '<html><body><p></p><p></p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['', ''],
 								    wantText: ['', ''],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    noteToSelf: '<p></p>should create a line break but not break numbering',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
 								  nestedOl: {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    description: 'Tests if ols properly get line numbers when in a normal OL',
 								    html: '<html><body>a<ol><li>b<ol><li>c</li></ol></ol>notlist<p>foo</p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+1', '*0*1*2*3+1+1', '*0*4*2*5+1+1', '+7', '+3'],
 								    wantText: ['a', '*b', '*c', 'notlist', 'foo'],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
-												cc tests: enable second nestedOL test

											
										
										
											2020-12-18 06:40:33 +01:00
+								  nestedOl2: {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    description: 'First item being an UL then subsequent being OL will fail',
 								    html: '<html><body><ul><li>a<ol><li>b</li><li>c</li></ol></li></ul></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+1', '*0*1*2*3+1+1', '*0*4*2*5+1+1'],
 								    wantText: ['a', '*b', '*c'],
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    noteToSelf: 'Ensure empty P does not induce line attribute marker, wont this break the editor?',
 								    disabled: true,
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								  },
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  lineDontBreakOL: {
 								    description: 'A single completely empty line break within an ol should NOT reset count',
 								    html: '<html><body><ol><li>should be 1</li><p></p><li>should be 2</li><li>should be 3</li></ol><p></p></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: [],
 								    wantText: ['*should be 1', '*should be 2', '*should be 3'],
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    noteToSelf: "<p></p>should create a line break but not break numbering -- This is what I can't get working!",
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    disabled: true,
 								  },
-												tests: Ignore head tag on import / improved contentcollector tests

* fix accidental write to global variable
properly show pending tests
log test name in suite
better log output for received/expected strings

* cc tests: enable second nestedOL test

* ignore the head tag on import
											
										
										
											2020-12-18 10:37:37 +01:00
+								  ignoreAnyTagsOutsideBody: {
 								    description: 'Content outside body should be ignored',
 								    html: '<html><head><title>title</title><style></style></head><body>empty<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+5'],
 								    wantText: ['empty'],
-												tests: Ignore head tag on import / improved contentcollector tests

* fix accidental write to global variable
properly show pending tests
log test name in suite
better log output for received/expected strings

* cc tests: enable second nestedOL test

* ignore the head tag on import
											
										
										
											2020-12-18 10:37:37 +01:00
+								  },
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  lineWithMultipleSpaces: {
 								    description: 'Multiple spaces should be preserved',
 								    html: '<html><body>Text with  more   than    one space.<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+10'],
 								    wantText: ['Text with  more   than    one space.'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  lineWithMultipleNonBreakingAndNormalSpaces: {
 								    description: 'non-breaking and normal space should be preserved',
 								    html: '<html><body>Text&nbsp;with&nbsp; more&nbsp;&nbsp;&nbsp;than   &nbsp;one space.<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+10'],
 								    wantText: ['Text with  more   than    one space.'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  multiplenbsp: {
 								    description: 'Multiple nbsp should be preserved',
 								    html: '<html><body>&nbsp;&nbsp;<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+2'],
 								    wantText: ['  '],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  multipleNonBreakingSpaceBetweenWords: {
 								    description: 'Multiple nbsp between words ',
 								    html: '<html><body>&nbsp;&nbsp;word1&nbsp;&nbsp;word2&nbsp;&nbsp;&nbsp;word3<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+m'],
 								    wantText: ['  word1  word2   word3'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  nonBreakingSpacePreceededBySpaceBetweenWords: {
 								    description: 'A non-breaking space preceeded by a normal space',
 								    html: '<html><body> &nbsp;word1 &nbsp;word2 &nbsp;word3<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+l'],
 								    wantText: ['  word1  word2  word3'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  nonBreakingSpaceFollowededBySpaceBetweenWords: {
 								    description: 'A non-breaking space followed by a normal space',
 								    html: '<html><body>&nbsp; word1&nbsp; word2&nbsp; word3<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+l'],
 								    wantText: ['  word1  word2  word3'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  spacesAfterNewline: {
 								    description: 'Don\'t collapse spaces that follow a newline',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<!doctype html><html><body>something<br>             something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+9', '+m'],
 								    wantText: ['something', '             something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  spacesAfterNewlineP: {
 								    description: 'Don\'t collapse spaces that follow a empty paragraph',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<!doctype html><html><body>something<p></p>             something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+9', '', '+m'],
 								    wantText: ['something', '', '             something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  spacesAtEndOfLine: {
 								    description: 'Don\'t collapse spaces that preceed/follow a newline',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<html><body>something            <br>             something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+l', '+m'],
 								    wantText: ['something            ', '             something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  spacesAtEndOfLineP: {
 								    description: 'Don\'t collapse spaces that preceed/follow a empty paragraph',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<html><body>something            <p></p>             something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+l', '', '+m'],
 								    wantText: ['something            ', '', '             something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  nonBreakingSpacesAfterNewlines: {
 								    description: 'Don\'t collapse non-breaking spaces that follow a newline',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<html><body>something<br>&nbsp;&nbsp;&nbsp;something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+9', '+c'],
 								    wantText: ['something', '   something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  nonBreakingSpacesAfterNewlinesP: {
 								    description: 'Don\'t collapse non-breaking spaces that follow a paragraph',
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    html: '<html><body>something<p></p>&nbsp;&nbsp;&nbsp;something<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+9', '', '+c'],
 								    wantText: ['something', '', '   something'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  preserveSpacesInsideElements: {
 								    description: 'Preserve all spaces when multiple are present',
 								    html: '<html><body>Need <span> more </span> space<i>  s </i> !<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+h*0+4+2'],
 								    wantText: ['Need  more  space  s  !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  preserveSpacesAcrossNewlines: {
 								    description: 'Newlines and multiple spaces across newlines should be preserved',
 								    html: `
 								      <html><body>Need
 								          <span> more </span>
 								          space
 								          <i>  s </i>
 								          !<br></body></html>`,
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+19*0+4+b'],
 								    wantText: ['Need           more           space            s           !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  multipleNewLinesAtBeginning: {
 								    description: 'Multiple new lines at the beginning should be preserved',
 								    html: '<html><body><br><br><p></p><p></p>first line<br><br>second line<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['', '', '', '', '+a', '', '+b'],
 								    wantText: ['', '', '', '', 'first line', '', 'second line'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								  multiLineParagraph: {
 								    description: 'A paragraph with multiple lines should not loose spaces when lines are combined',
 								    html: `<html><body><p>
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								а б в г ґ д е є ж з и і ї й к л м н о
 								п р с т у ф х ц ч ш щ ю я ь</p>
 								</body></html>`,
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+1t'],
 								    wantText: ['а б в г ґ д е є ж з и і ї й к л м н о п р с т у ф х ц ч ш щ ю я ь'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								  multiLineParagraphWithPre: {
 								    description: 'lines in preformatted text should be kept intact',
 								    html: `<html><body><p>
-												tests: Fix invalid HTML in contentcollector tests

The HTML spec does not permit `<pre>` as a child of `<p>`.

											
										
										
											2021-01-24 09:31:45 +01:00
+								а б в г ґ д е є ж з и і ї й к л м н о</p><pre>multiple
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								lines
 								in
 								pre
-												tests: Fix invalid HTML in contentcollector tests

The HTML spec does not permit `<pre>` as a child of `<p>`.

											
										
										
											2021-01-24 09:31:45 +01:00
+								</pre><p>п р с т у ф х ц ч ш щ ю я
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								ь</p>
 								</body></html>`,
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+11', '+8', '+5', '+2', '+3', '+r'],
 								    wantText: [
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								      'а б в г ґ д е є ж з и і ї й к л м н о',
 								      'multiple',
 								      'lines',
 								      'in',
 								      'pre',
 								      'п р с т у ф х ц ч ш щ ю я ь',
 								    ],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  preIntroducesASpace: {
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								    description: 'pre should be on a new line not preceeded by a space',
 								    html: `<html><body><p>
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
-												tests: Fix invalid HTML in contentcollector tests

The HTML spec does not permit `<pre>` as a child of `<p>`.

											
										
										
											2021-01-24 09:31:45 +01:00
+								</p><pre>preline
 								</pre></body></html>`,
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+6', '+7'],
 								    wantText: ['    1 ', 'preline'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  dontDeleteSpaceInsideElements: {
 								    description: 'Preserve spaces on the beginning and end of a element',
 								    html: '<html><body>Need<span> more </span>space<i> s </i>!<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+f*0+3+1'],
 								    wantText: ['Need more space s !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  dontDeleteSpaceOutsideElements: {
 								    description: 'Preserve spaces outside elements',
 								    html: '<html><body>Need <span>more</span> space <i>s</i> !<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+g*0+1+2'],
 								    wantText: ['Need more space s !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  dontDeleteSpaceAtEndOfElement: {
 								    description: 'Preserve spaces at the end of an element',
 								    html: '<html><body>Need <span>more </span>space <i>s </i>!<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+g*0+2+1'],
 								    wantText: ['Need more space s !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
 								  dontDeleteSpaceAtBeginOfElements: {
 								    description: 'Preserve spaces at the start of an element',
 								    html: '<html><body>Need<span> more</span> space<i> s</i> !<br></body></html>',
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								    wantLineAttribs: ['+f*0+2+2'],
 								    wantText: ['Need more space s !'],
-												tests for spaces (#4594)


											
										
										
											2020-12-20 07:18:19 +01:00
+								  },
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								};
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								describe(__filename, function () {
-												cc tests: enable second nestedOL test

											
										
										
											2020-12-18 06:40:33 +01:00
+								  for (const test of Object.keys(tests)) {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								    const testObj = tests[test];
 								    describe(test, function () {
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								      if (testObj.disabled) {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        return xit('DISABLED:', test, function (done) {
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								          done();
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        });
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								      }
-												tests: Fix missing call to `done` callback

											
										
										
											2021-01-24 07:57:11 +01:00
+								      it(testObj.description, async function () {
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        const $ = cheerio.load(testObj.html); // Load HTML into Cheerio
-												tests: Ignore head tag on import / improved contentcollector tests

* fix accidental write to global variable
properly show pending tests
log test name in suite
better log output for received/expected strings

* cc tests: enable second nestedOL test

* ignore the head tag on import
											
										
										
											2020-12-18 10:37:37 +01:00
+								        const doc = $('body')[0]; // Creates a dom-like representation of HTML
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								        // Create an empty attribute pool
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        const apool = new AttributePool();
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								        // Convert a dom tree into a list of lines and attribute liens
 								        // using the content collector object
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        const cc = contentcollector.makeContentCollector(true, null, apool);
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								        cc.collectContent(doc);
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								        const result = cc.finish();
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								        const gotAttributes = result.lineAttribs;
 								        const wantAttributes = testObj.wantLineAttribs;
 								        const gotText = new Array(result.lines);
 								        const wantText = testObj.wantText;
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
-												tests: Replace "expected" with "want", "received" with "got"

"Got" and "want" are common terms for testing, plus this fixes a
spelling mistake ("received" was misspelled as "recieved").

											
										
										
											2021-01-24 07:54:14 +01:00
+								        assert.deepEqual(gotText[0], wantText);
 								        assert.deepEqual(gotAttributes, wantAttributes);
-												tests: Include the filename in the test output

Also some minor consistency cleanups.

											
										
										
											2020-10-10 00:19:46 +02:00
+								      });
 								    });
 								  }
 								});
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
 								function arraysEqual(a, b) {
 								  if (a === b) return true;
 								  if (a == null || b == null) return false;
-												lint: Fix some straightforward ESLint errors

											
										
										
											2021-01-24 06:56:11 +01:00
+								  if (a.length !== b.length) return false;
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
 								  // If you don't care about the order of the elements inside
 								  // the array, you should sort both arrays here.
 								  // Please note that calling sort on an array will modify that array.
 								  // you might want to clone your array first.
-												lint: Run `eslint --fix` on `bin/` and `tests/`

											
										
										
											2020-11-23 19:21:51 +01:00
+								  for (let i = 0; i < a.length; ++i) {
-												tests/editor/ul/li/ol/import/export: Introduce contentcollector.js tests & various OL/UL/LI related bugfixes

1. Introduce contentcollector.js backend tests
1. Fix issue with OL LI items not being properly numbered after import
1. Fix issue with nested OL LI items being improperly numbered on export
1. Fix issue with new lines not being introduced after lists in on import #3961
1. Sanitize HTML on the way in (import)
1. Fix ExportHTML CSS because it needs to support OL > LI > OL not OL > OL [The latter being the correct format]
1. Fix backend tests.
											
										
										
											2020-06-05 21:54:16 +02:00
+								    if (a[i] !== b[i]) return false;
 								  }
 								  return true;
 								}