devinsy/kiss4web
devinsy/kiss4web
1
0
Fork 0
Code Issues 1 Pull requests Releases Activity

Fix bug with cookie value which need to be encoded/decoded.

Browse source
This commit is contained in:
Christian P. MOMON 2013-12-03 17:02:11 +01:00
parent 3a2cdbad34
commit 524c5b1fa6
1 changed files with 37 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/fr/devinsy/kiss4web/CookieHelper.java
View file

@ -1,5 +1,7 @@
package fr.devinsy.kiss4web; package fr.devinsy.kiss4web;
import java.io.UnsupportedEncodingException;
import javax.servlet.http.Cookie; import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
@ -33,28 +35,36 @@ public class CookieHelper
} }
/** /**
* * Warning: value is UTF-8 URLEncoded!
*/ */
static public Cookie buildCookie(final String name, final String value, final int duration, final Scope secure) static public Cookie buildCookie(final String name, final String value, final int duration, final Scope secure)
{ {
Cookie result; Cookie result;
// //
result = new Cookie(name, value); try
result.setMaxAge(duration); {
result.setPath("/"); result = new Cookie(name, java.net.URLEncoder.encode(value, "UTF-8"));
result.setMaxAge(duration);
result.setPath("/");
// //
boolean secureValue; boolean secureValue;
if (secure == Scope.HTTPS_ONLY) if (secure == Scope.HTTPS_ONLY)
{ {
secureValue = true; secureValue = true;
}
else
{
secureValue = false;
}
result.setSecure(secureValue);
} }
else catch (UnsupportedEncodingException exception)
{ {
secureValue = false; exception.printStackTrace();
throw new IllegalArgumentException("value is unsupported encoding.");
} }
result.setSecure(secureValue);
// //
return (result); return (result);
@ -135,21 +145,29 @@ public class CookieHelper
} }
/** /**
* * Note: value is UTF-8 decoded.
*/ */
static public Object getCookieValue(final Cookie[] cookies, final String key) static public Object getCookieValue(final Cookie[] cookies, final String key)
{ {
Object result; Object result;
Cookie cookie = getCookie(cookies, key); try
{
Cookie cookie = getCookie(cookies, key);
if (cookie == null) if (cookie == null)
{ {
result = null; result = null;
}
else
{
result = java.net.URLDecoder.decode(cookie.getValue(), "UTF-8");
}
} }
else catch (UnsupportedEncodingException exception)
{ {
result = cookie.getValue(); exception.printStackTrace();
throw new IllegalArgumentException();
} }
// //